Правки дз 4

homework/4.sql

@@ -60,6 +60,8 @@ insert into numeric_constants("key", "value") values ('dtv', 0.3), ('mp', 15.9)
 CREATE OR REPLACE FUNCTION calculate_average_deviation(temperature NUMERIC)
 RETURNS TABLE(height INT, deviation NUMERIC) AS $$
 DECLARE
+    dtv NUMERIC;
+    mp NUMERIC;
     t0 NUMERIC;
     delta_t NUMERIC;
     deviation_value NUMERIC;
@@ -67,10 +69,20 @@ DECLARE
     deviation_unit NUMERIC;
     row_data RECORD;
 BEGIN
-    t0 := temperature + (select value from numeric_constants where key = 'dtv' limit 1);
+    select value into dtv from numeric_constants where key = 'dtv' limit 1;
+    select value into mp from numeric_constants where key = 'mp' limit 1;
+    
+    IF dtv_value IS NULL THEN
+        RAISE NOTICE 'Константа dtv не найдена';
+    END IF;
+    IF mp_value IS NULL THEN
+        RAISE NOTICE 'Константа mp не найдена';
+    END IF;
+    
+    t0 := temperature + dtv;
 	raise notice 't0 %', t0;
 
-    delta_t := t0 - (select value from numeric_constants where key = 'mp' limit 1);
+    delta_t := t0 - mp;
     delta_t := ROUND(delta_t);
 
     FOR row_data IN SELECT * FROM average_deviations_temperature LOOP
@@ -93,15 +105,14 @@ BEGIN
 END;
 $$ LANGUAGE plpgsql;
 
-
-select
-u.name as "ФИО",
-mr.name as "Должность",
-COUNT(b.id) as "Количество измерений",
-SUM(case validate_measurement(p.temperature, p.pressure, p.wind_direction) when null then 1 else 0 end) as "Количество ошибочных данных"
-from users u 
-join ranks mr on u.rank_id = mr.id
-join measurement_batch b on u.id = b.user_id
-join measurement_params p on p.measurement_batch_id = b.id
-group by u.name, mr.name
-order by "Количество ошибочных данных" desc;
+select concat, count(*)
+from (
+	select *, validate_measurement(p.temperature, p.pressure, p.wind_direction), concat(r.name, ' ', u.name
+)
+from measurement_params p
+join measurement_batch b on b.id = p.measurement_batch_id
+join users u on u.id = b.user_id
+join ranks r on r.id = u.rank_id)
+where validate_measurement is null
+group by concat 
+order by count(*) desc;